Add workflow and CMake support for formatting #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
requested review from
pmwkaa,
nikkhils and
svenklemm
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #3340 +/- ##
==========================================
+ Coverage 90.57% 90.58% +0.01%
==========================================
Files 211 211
Lines 35536 35536
==========================================
+ Hits 32188 32192 +4
+ Misses 3348 3344 -4
Continue to review full report at Codecov.
|
afiskon
approved these changes
Jun 17, 2021
mfundul
reviewed
Jun 17, 2021
Comment on lines
+1
to
+7
| #!/bin/bash | ||
|
|
||
| SCRIPTDIR=$(cd $(dirname $0); pwd) | ||
| BASEDIR=$(dirname $SCRIPTDIR) | ||
|
|
||
| find $BASEDIR -name CMakeLists.txt -exec cmake-format -i {} + | ||
| find $BASEDIR/src $BASEDIR/test $BASEDIR/tsl -name '*.cmake' -exec cmake-format -i {} + |
There was a problem hiding this comment.
Where is this script executed?
There was a problem hiding this comment.
In the custom target inside the top-level CMakeLists.txt.
mfundul
approved these changes
Jun 17, 2021
Add a workflow to check that CMake files are correctly formatted as well as a custom target to format CMake files in the repository. This commit also runs the formatting on all CMake files in the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a workflow to check that CMake files are correctly formatted as
well as a custom target to format CMake files in the repository. This
commit also runs the formatting on all CMake files in the repository.